Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: allow empty arrays to passed to inArray and notInArray #1664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Angelelz
Copy link
Collaborator

close #1295

  • When passed an empty array inArray now returns false and notInArray now return true instead of throwing.
  • Added tests to all dialects.

Please see this comment for a compelling argument for this change.

@Angelelz Angelelz force-pushed the feat-allow-empty-arrays-for-inArray branch from 1c694c2 to 41bde97 Compare December 27, 2023 03:09
@RemiPeruto
Copy link
Contributor

@Angelelz or @philippdormann is it possible for one of you to make these changes go to one of the next releases please 🙏 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Allow to pass empty values to inArray
3 participants